Re: [Qemu-devel] [PATCH 7/9] spice: add mouse

[Gerd Hoffmann]

  Hi,

> > +static void mouse_motion(SpiceMouseInstance *sin, int dx, int dy, int
> > dz,
> > + uint32_t buttons_state)
> > +{
> > + kbd_mouse_event(dx, dy, dz, buttons_state);
>
> dz is an odd interface. We use it to represent additional buttons which
> really makes no sense. If you still can, I'd suggest moving dz into
> buttons_state.

Again this is libspice interface (and I think also wire protocol), so I 
can't change it.  I can convert dz into some button_mask bits before 
calling kbd_mouse_event, but looking at the vnc code it seems qemu 
expects the mouse wheel events being passed via dz not button_state.

> Previous comment still applies though, you should explicitly convert the
> button_states from QEMU format to Spice format to future proof.

Ok.

cheers,
  Gerd