[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 14/15] vnc: tight: tweak adaptive tight setting
From: |
Corentin Chary |
Subject: |
Re: [Qemu-devel] [PATCH 14/15] vnc: tight: tweak adaptive tight settings |
Date: |
Wed, 11 Aug 2010 15:17:03 +0200 |
On Wed, Aug 11, 2010 at 3:06 PM, Chris Krumme
<address@hidden> wrote:
> Hello Corentin,
>
> On 08/11/2010 12:49 AM, Corentin Chary wrote:
>>
>> The force_jpeg threshold was too low.
>>
>> Signed-off-by: Corentin Chary<address@hidden>
>> ---
>> qemu-thread.c | 1 +
>> ui/vnc-enc-tight.c | 20 ++++++++++----------
>> 2 files changed, 11 insertions(+), 10 deletions(-)
>>
>> diff --git a/qemu-thread.c b/qemu-thread.c
>> index fbc78fe..4094c51 100644
>> --- a/qemu-thread.c
>> +++ b/qemu-thread.c
>> @@ -22,6 +22,7 @@
>> static void error_exit(int err, const char *msg)
>> {
>> fprintf(stderr, "qemu: %s: %s\n", msg, strerror(err));
>> + char *p = NULL; *p = 1;
>>
>
> I do not believe this is the official way to do an assert. It is also not
> documented in the change comments.
>
> Thanks
>
> Chris
Ooops .. that sould not be in the patch, it was only a test... I'll
re-send it tomorow, sorry for that :/.
--
Corentin Chary
http://xf.iksaif.net
- [Qemu-devel] [PATCH 06/15] vnc: palette: add palette_init calls, (continued)
- [Qemu-devel] [PATCH 06/15] vnc: palette: add palette_init calls, Corentin Chary, 2010/08/11
- [Qemu-devel] [PATCH 07/15] vnc: palette: and fill and color calls., Corentin Chary, 2010/08/11
- [Qemu-devel] [PATCH 09/15] vnc: fix uint8_t comparisons with negative values, Corentin Chary, 2010/08/11
- [Qemu-devel] [PATCH 08/15] vnc: Add ZRLE and ZYWRLE encodings., Corentin Chary, 2010/08/11
- [Qemu-devel] [PATCH 10/15] vnc: fix lossy rect refreshing, Corentin Chary, 2010/08/11
- [Qemu-devel] [PATCH 11/15] bitmap: add a generic bitmap and bitops library, Corentin Chary, 2010/08/11
- [Qemu-devel] [PATCH 12/15] vnc: use the new generic bitmap functions, Corentin Chary, 2010/08/11
- [Qemu-devel] [PATCH 13/15] vnc: don't try to send bigger updates that client height, Corentin Chary, 2010/08/11
- [Qemu-devel] [PATCH 14/15] vnc: tight: tweak adaptive tight settings, Corentin Chary, 2010/08/11
- [Qemu-devel] [PATCH 15/15] vnc: add a non-adaptive option, Corentin Chary, 2010/08/11