[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 3/3] savevm: prevent snapshot overwriting and ge
From: |
Miguel Di Ciurcio Filho |
Subject: |
[Qemu-devel] Re: [PATCH 3/3] savevm: prevent snapshot overwriting and generate a default name |
Date: |
Fri, 30 Jul 2010 11:42:44 -0300 |
On Fri, Jul 30, 2010 at 10:39 AM, Luiz Capitulino
<address@hidden> wrote:
>>
>> TODO: I have no clue on how to create a timestamp string when using Windows.
>
> So, what happens on windows?
>
I've found some code in bdrv_snapshot_dump() that formats a timestamp
when using Windows. I will use it as a basis.
> Also, please, avoid making changes which are unrelated to the patch, like:
>
>> the_end:
>> - if (saved_vm_running)
>> + if (saved_vm_running) {
>> vm_start();
>> + }
>> }
>>
Ack. Coding style cleanups must have a separate patch :-D
Regards,
Miguel