qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 07/12] linux-user: Load symbols from the interpr


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH 07/12] linux-user: Load symbols from the interpreter.
Date: Tue, 27 Jul 2010 12:59:47 -0700
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.7) Gecko/20100720 Fedora/3.1.1-1.fc13 Thunderbird/3.1.1

On 07/27/2010 11:45 AM, malc wrote:
>> +    syms = realloc(syms, nsyms * sizeof(*syms));
> 
> Realloc can fail here.

I don't believe it can.  This (pre-existing) statement *reduces*
the existing allocation of syms.  I'd be surprised if any malloc
implementation fails on a size reduction.

That said, I'd be happy enough to eliminate the call entirely.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]