[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH-V3 03/24] virtio-9p: Return correct error from v9fs_
From: |
Venkateswararao Jujjuri (JV) |
Subject: |
[Qemu-devel] [PATCH-V3 03/24] virtio-9p: Return correct error from v9fs_remove |
Date: |
Thu, 22 Jul 2010 08:57:50 -0700 |
From: Sripathi Kodi <address@hidden>
Signed-off-by: Sripathi Kodi <address@hidden>
In v9fs_remove_post_remove() we currently ignore the error returned by
the previous call to remove() and return an error only if freeing the
fid fails. However, the client expects to see the error from remove().
Currently the client falsely thinks that the remove call has always
succeeded. For example, doing rmdir on a non-empty directory does
not return ENOTEMPTY.
With this patch we ignore the error from free_fid(). The client cannot
use this error value anyway.
Signed-off-by: Sripathi Kodi <address@hidden>
Signed-off-by: Venkateswararao Jujjuri <address@hidden>
---
hw/virtio-9p.c | 11 ++++++-----
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c
index 20560e5..0540a74 100644
--- a/hw/virtio-9p.c
+++ b/hw/virtio-9p.c
@@ -1877,14 +1877,15 @@ static void v9fs_flush(V9fsState *s, V9fsPDU *pdu)
static void v9fs_remove_post_remove(V9fsState *s, V9fsRemoveState *vs,
int err)
{
- /* For TREMOVE we need to clunk the fid even on failed remove */
- err = free_fid(s, vs->fidp->fid);
if (err < 0) {
- goto out;
+ err = -errno;
+ } else {
+ err = vs->offset;
}
- err = vs->offset;
-out:
+ /* For TREMOVE we need to clunk the fid even on failed remove */
+ free_fid(s, vs->fidp->fid);
+
complete_pdu(s, vs->pdu, err);
qemu_free(vs);
}
--
1.6.5.2
- [Qemu-devel] [PATCH-V3 24/24] virtio-9p: Fix formatting issues in v9fs_wstat_post_chown(), (continued)
- [Qemu-devel] [PATCH-V3 24/24] virtio-9p: Fix formatting issues in v9fs_wstat_post_chown(), Venkateswararao Jujjuri (JV), 2010/07/22
- [Qemu-devel] [PATCH-V3 08/24] [virtio-9p] Make v9fs_do_utimensat accept timespec structures instead of v9stat., Venkateswararao Jujjuri (JV), 2010/07/22
- [Qemu-devel] [PATCH-V3 18/24] virtio-9p: Implement TXATTRWALK, Venkateswararao Jujjuri (JV), 2010/07/22
- [Qemu-devel] [PATCH-V3 13/24] qemu: virtio-9p: Implement TMKNOD, Venkateswararao Jujjuri (JV), 2010/07/22
- [Qemu-devel] [PATCH-V3 15/24] rename - change name of file or directory, Venkateswararao Jujjuri (JV), 2010/07/22
- [Qemu-devel] [PATCH-V3 16/24] qemu: virtio-9p: Implement LOPEN, Venkateswararao Jujjuri (JV), 2010/07/22
- [Qemu-devel] [PATCH-V3 19/24] virtio-9p: Implement TXATTRCREATE, Venkateswararao Jujjuri (JV), 2010/07/22
- [Qemu-devel] [PATCH-V3 23/24] virtio-9p: Fix the memset usage, Venkateswararao Jujjuri (JV), 2010/07/22
- [Qemu-devel] [PATCH-V3 22/24] virtio-9p: Use lchown which won't follow symlink, Venkateswararao Jujjuri (JV), 2010/07/22
- [Qemu-devel] [PATCH-V3 20/24] virtio-9p: Hide user.virtfs xattr in case of mapped security., Venkateswararao Jujjuri (JV), 2010/07/22
- [Qemu-devel] [PATCH-V3 03/24] virtio-9p: Return correct error from v9fs_remove,
Venkateswararao Jujjuri (JV) <=
- [Qemu-devel] [PATCH-V3 07/24] virtio-9p: Do not reset atime, Venkateswararao Jujjuri (JV), 2010/07/22
- [Qemu-devel] [PATCH-V3 06/24] virtio-9p: getattr server implementation for 9P2000.L protocol., Venkateswararao Jujjuri (JV), 2010/07/22
- [Qemu-devel] [PATCH-V3 04/24] [V4] virtio-9p: readdir implementation for 9p2000.L, Venkateswararao Jujjuri (JV), 2010/07/22