[Qemu-devel] Re: [PATCH v3 2/2] monitor: Convert 'info qdm' to QMP

[Anthony Liguori]

On 07/21/2010 12:51 PM, Daniel P. Berrange wrote:
> On Wed, Jul 21, 2010 at 02:42:28PM -0300, Luiz Capitulino wrote:
>    
> > On Mon, 19 Jul 2010 13:51:27 -0300
> > Miguel Di Ciurcio Filho<address@hidden>  wrote:
> >
> >      
> > > Converts the 'info qdm' command to QMP, allowing the discovery of all devices
> > > known to the QEMU binary without relying on command line paramaters like
> > > -device ? and -device devtype,?
> > >
> > > This change does not modify the output of the 'info qdm' monitor command.
> > >
> > > Signed-off-by: Miguel Di Ciurcio Filho<address@hidden>
> > > diff --git a/monitor.c b/monitor.c
> > > index 45fd482..66810f2 100644
> > > --- a/monitor.c
> > > +++ b/monitor.c
> > > @@ -2565,7 +2565,8 @@ static const mon_cmd_t info_cmds[] = {
> > >           .args_type  = "",
> > >           .params     = "",
> > >           .help       = "show qdev device model list",
> > > -        .mhandler.info = do_info_qdm,
> > > +        .user_print = do_info_qdm_print,
> > > +        .mhandler.info_new = do_info_qdm,
> > >        
> > Haven't we agreed on calling this query-available-devices or something
> > like that?
> >      
> That's getting rather verbose for a name ! How about just
> 'query-dev-types' (anticipating future query-netdev-types,
> query-chardev-types, commands etc, too)
>    

I know we're still trying to recover from the great bit shortage of '09 
but I think we can afford to spare some here to make the names readable :-)

Good names are part of good documentation.  If it's not entirely obvious 
what the function does from it's name, it's probably a bad name (in the 
context of a wire protocol).

Regards,

Anthony Liguori

> Daniel
>