[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] ide/atapi: add support for GET EVENT STATUS NOT
From: |
Aurelien Jarno |
Subject: |
[Qemu-devel] Re: [PATCH] ide/atapi: add support for GET EVENT STATUS NOTIFICATION |
Date: |
Mon, 19 Jul 2010 17:36:31 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Mon, Jul 19, 2010 at 05:28:40PM +0200, Kevin Wolf wrote:
> Am 19.07.2010 15:53, schrieb Aurelien Jarno:
> > The GET EVENT STATUS NOTIFICATION is a mandatory command according
> > to MMC-3, even if event status notification is not supported.
> >
> > This patch adds support for this command. It returns NEA ("No Event
> > Available") with an empty "Supported Event Classes" to show that it
> > doesn't event support status notification. If asychronous operation is
> > requested, which requires NCQ support, it returns an error according
> > to the specifications.
> >
> > This fixes HAL support on FreeBSD and derivatives, which fill up the
> > logs every second with:
> >
> > acd0: FAILURE - unknown CMD (0x03) ILLEGAL REQUEST asc=0x20 ascq=0x00
> >
> > Signed-off-by: Aurelien Jarno <address@hidden>
>
> Looks good to me.
Thanks for the review.
> Would you prefer me to take this into the block branch (actually, I have
> already done this) or are you going to commit directly? This might
I am fine to get it through the block branch.
> actually be something that should be in 0.13.
agreed.
> Have you tested some more OSes to ensure that they don't start to expect
> events to actually work now the command "works"? I didn't see any
> problems in a quick test with Linux, but you never know.
>
Besides FreeBSD, I have tested without problem Linux, NetBSD and
OpenBSD, though I haven't tested them more then booting and mounting a
CD-ROM.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net