|
From: | Alexander Graf |
Subject: | Re: [Qemu-devel] [PATCH 2/2] fw_cfg: Add blit operation for copying kernel, initrd, .. |
Date: | Sun, 18 Jul 2010 23:13:10 +0200 |
On 18.07.2010, at 23:12, Richard W.M. Jones wrote: > On Sun, Jul 18, 2010 at 10:47:27PM +0200, Alexander Graf wrote: >>> + if (blitaddr == 0) >>> + ret = 0; /* guest must set up a blit address beforehand */ >> >> Coding style. I'm also not sure this has to be special-cased. Why care if >> the guest wants to corrupt its own address space? >> > > I agree that we don't need to special-case this. But what was the > coding style issue? (the comment?) Qemu's CODING_STYLE file requires you to do things like this: if (x) { foo(); } else { bar(); } Alex
[Prev in Thread] | Current Thread | [Next in Thread] |