[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [SeaBIOS] [PATCH 2/7] seabios: shadow: make device find
|
From: |
Kevin O'Connor |
|
Subject: |
[Qemu-devel] Re: [SeaBIOS] [PATCH 2/7] seabios: shadow: make device finding more generic. |
|
Date: |
Mon, 12 Jul 2010 20:59:14 -0400 |
|
User-agent: |
Mutt/1.5.20 (2009-12-10) |
On Mon, Jul 12, 2010 at 08:47:47PM +0900, Isaku Yamahata wrote:
> pam register offset is north bridge specific.
> So determine the offset based on found north bridge.
Is it really just the offset that is north bridge specific? I thought
the entire process was very north bridge specific.
If so, I don't think it makes sense to pass back the pam0 register -
instead the north bridge specific code should do the necessary work
(using helper functions if possible).
I have the same concern with part 3 and 4 of this series.
-Kevin
- [Qemu-devel] [PATCH 0/7] abstract chipset(i440fx) specific register operation., Isaku Yamahata, 2010/07/12
- [Qemu-devel] [PATCH 3/7] seabios: smm: move out piix4 specific logic to dev-i440fx.c, Isaku Yamahata, 2010/07/12
- [Qemu-devel] [PATCH 5/7] seabios: acpi: move acpi definitions to acpi.h from acpi.c, Isaku Yamahata, 2010/07/12
- [Qemu-devel] [PATCH 1/7] seabios: pci: introduce helper function to find device from table and initialize it., Isaku Yamahata, 2010/07/12
- [Qemu-devel] [PATCH 7/7] seabios: acpi: clean up of finding pm device., Isaku Yamahata, 2010/07/12
- [Qemu-devel] [PATCH 4/7] seabios: smm_init: move out i440fx smram operation into dev-i440fx.c, Isaku Yamahata, 2010/07/12
- [Qemu-devel] [PATCH 6/7] seabios: acpi: split out piix4 pm logic., Isaku Yamahata, 2010/07/12
- [Qemu-devel] Re: [SeaBIOS] [PATCH 0/7] abstract chipset(i440fx) specific register operation., Kevin O'Connor, 2010/07/12