[Qemu-devel] Re: [PATCH v2 0/4] introduce NEED_GLOBAL_ENV

[Blue Swirl]

Thanks, applied patches 1 to 3.

On Tue, Jun 29, 2010 at 7:58 AM, Paolo Bonzini <address@hidden> wrote:
> Let's start the cleanups from the feature required by Blue Swirl.
> I also include here a baby step towards removing eminently TCG-related
> stuff from cpu.h.
>
> After this series, only a bunch of files will include exec-all.h,
> instead of getting it indirectly from cpu.h.
>
> Note that (as sworn in the previous submission) exec.h is only included
> by files that need the global register variable (i.e. cpu-exec.c and
> target-*/op_helper.c), and this is the same subset that gets
> NEED_GLOBAL_ENV in this patchset.
>
> i386 and sparc have functions declared in cpu.h that are in op_helper.c.
> I checked that these do not need the global variable, but it would be
> nice to cleanup those too.
>
> v1->v2: leave in #undefs, add static to cpu_mips_tlb_flush
>
> Paolo Bonzini (4):
>  remove unused stuff from */exec.h
>  move cpu_pc_from_tb to target-*/exec.h
>  remove exec-all.h inclusion from cpu.h
>  require #define NEED_GLOBAL_ENV for files that need the global
>    register variable
>
>  cpu-exec.c                    |    2 ++
>  exec-all.h                    |    4 ++++
>  gdbstub.c                     |    1 +
>  hw/xen_domainbuild.c          |    1 +
>  kvm-stub.c                    |    1 +
>  monitor.c                     |    1 +
>  target-alpha/cpu.h            |    6 ------
>  target-alpha/exec.h           |    9 +++++----
>  target-alpha/op_helper.c      |    1 +
>  target-arm/cpu.h              |    6 ------
>  target-arm/exec.h             |    8 ++++++--
>  target-arm/op_helper.c        |    1 +
>  target-cris/cpu.h             |    6 ------
>  target-cris/exec.h            |   11 ++++++-----
>  target-cris/op_helper.c       |    1 +
>  target-i386/cpu.h             |    7 -------
>  target-i386/exec.h            |    8 ++++++--
>  target-i386/op_helper.c       |    3 ++-
>  target-m68k/cpu.h             |    6 ------
>  target-m68k/exec.h            |    8 ++++++--
>  target-m68k/op_helper.c       |    2 ++
>  target-microblaze/cpu.h       |    6 ------
>  target-microblaze/exec.h      |   10 ++++++----
>  target-microblaze/op_helper.c |    1 +
>  target-mips/cpu.h             |    8 --------
>  target-mips/exec.h            |   17 +++++++----------
>  target-mips/op_helper.c       |    9 ++++++++-
>  target-ppc/cpu.h              |    6 ------
>  target-ppc/exec.h             |    7 +++++--
>  target-ppc/op_helper.c        |    2 ++
>  target-s390x/cpu.h            |    6 ------
>  target-s390x/exec.h           |    8 ++++++--
>  target-s390x/op_helper.c      |    1 +
>  target-sh4/cpu.h              |    7 -------
>  target-sh4/exec.h             |    8 ++++++--
>  target-sh4/op_helper.c        |    2 ++
>  target-sparc/cpu.h            |    7 -------
>  target-sparc/exec.h           |    8 ++++++--
>  target-sparc/op_helper.c      |    1 +
>  39 files changed, 97 insertions(+), 110 deletions(-)
>
>