[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 02/11] block migration: Fix test for read-only drive
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 02/11] block migration: Fix test for read-only drive |
Date: |
Wed, 30 Jun 2010 13:55:33 +0200 |
init_blk_migration_it() skips drives with type hint BDRV_TYPE_CDROM.
The intention is to skip read-only drives. However, BDRV_TYPE_CDROM
is only a hint. It is currently sufficent for read-only. But it's
not necessary, and it may not remain sufficient.
Use bdrv_is_read_only() instead.
Signed-off-by: Markus Armbruster <address@hidden>
---
block-migration.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block-migration.c b/block-migration.c
index 7d04d6d..7337349 100644
--- a/block-migration.c
+++ b/block-migration.c
@@ -236,7 +236,7 @@ static void init_blk_migration_it(void *opaque,
BlockDriverState *bs)
BlkMigDevState *bmds;
int64_t sectors;
- if (bs->type == BDRV_TYPE_HD) {
+ if (!bdrv_is_read_only(bs)) {
sectors = bdrv_getlength(bs) >> BDRV_SECTOR_BITS;
if (sectors == 0) {
return;
--
1.6.6.1
- [Qemu-devel] [PATCH 00/11] Still more block related fixes and cleanups, Markus Armbruster, 2010/06/30
- [Qemu-devel] [PATCH 02/11] block migration: Fix test for read-only drive,
Markus Armbruster <=
- [Qemu-devel] [PATCH 01/11] blockdev: Clean up how readonly persists across virtual media change, Markus Armbruster, 2010/06/30
- [Qemu-devel] [PATCH 10/11] ide: Reject readonly drives unless CD-ROM, Markus Armbruster, 2010/06/30
- [Qemu-devel] [PATCH 07/11] ide: Improve error messages, Markus Armbruster, 2010/06/30
- [Qemu-devel] [PATCH 03/11] raw-posix: Don't "try harder" for BDRV_TYPE_CDROM, Markus Armbruster, 2010/06/30
- [Qemu-devel] [PATCH 08/11] ide: Replace IDEState members is_cdrom, is_cf by drive_kind, Markus Armbruster, 2010/06/30
- [Qemu-devel] [PATCH 09/11] ide: Make ide_init_drive() return success, Markus Armbruster, 2010/06/30
- [Qemu-devel] [PATCH 05/11] fdc: Reject unimplemented error actions, Markus Armbruster, 2010/06/30
- [Qemu-devel] [PATCH 11/11] ide: Reject invalid CHS geometry, Markus Armbruster, 2010/06/30
- [Qemu-devel] [PATCH 06/11] qdev: Don't hw_error() in qdev_init_nofail(), Markus Armbruster, 2010/06/30
- [Qemu-devel] [PATCH 04/11] scsi: Reject unimplemented error actions, Markus Armbruster, 2010/06/30