[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 02/12] ide: Make it explicit that ide_create_dri
|
From: |
Christoph Hellwig |
|
Subject: |
[Qemu-devel] Re: [PATCH 02/12] ide: Make it explicit that ide_create_drive() can't fail |
|
Date: |
Fri, 25 Jun 2010 21:40:14 +0200 |
|
User-agent: |
Mutt/1.3.28i |
On Fri, Jun 25, 2010 at 06:53:22PM +0200, Markus Armbruster wrote:
> All callers of ide_create_drive() ignore its value. Currently
> harmless, because it fails only when qdev_init() fails, which fails
> only when ide_drive_initfn() fails, which never fails.
>
> Brittle. Change it to die instead of silently ignoring failure.
>
> Signed-off-by: Markus Armbruster <address@hidden>
Looks good,
Reviewed-by: Christoph Hellwig <address@hidden>
- [Qemu-devel] Re: [PATCH 09/12] savevm: Survive hot-unplug of snapshot device, (continued)
- [Qemu-devel] [PATCH 10/12] block: Fix virtual media change for if=none, Markus Armbruster, 2010/06/25
- [Qemu-devel] [PATCH 11/12] ide: Make PIIX and ISA IDE init functions return the qdev, Markus Armbruster, 2010/06/25
- [Qemu-devel] [PATCH 07/12] blockdev: drive_get_by_id() is no longer used, remove, Markus Armbruster, 2010/06/25
- [Qemu-devel] [PATCH 02/12] ide: Make it explicit that ide_create_drive() can't fail, Markus Armbruster, 2010/06/25
- [Qemu-devel] Re: [PATCH 02/12] ide: Make it explicit that ide_create_drive() can't fail,
Christoph Hellwig <=
- [Qemu-devel] [PATCH 04/12] blockdev: New drive_of_blockdev(), Markus Armbruster, 2010/06/25
- [Qemu-devel] Re: [PATCH 04/12] blockdev: New drive_of_blockdev(), Christoph Hellwig, 2010/06/25
- [Qemu-devel] Re: [PATCH 04/12] blockdev: New drive_of_blockdev(), Markus Armbruster, 2010/06/26
- [Qemu-devel] Re: [PATCH 04/12] blockdev: New drive_of_blockdev(), Christoph Hellwig, 2010/06/26
- Re: [Qemu-devel] Re: [PATCH 04/12] blockdev: New drive_of_blockdev(), Markus Armbruster, 2010/06/26
- Re: [Qemu-devel] Re: [PATCH 04/12] blockdev: New drive_of_blockdev(), Christoph Hellwig, 2010/06/27
- [Qemu-devel] Re: [PATCH 04/12] blockdev: New drive_of_blockdev(), Paolo Bonzini, 2010/06/28
- [Qemu-devel] Re: [PATCH 04/12] blockdev: New drive_of_blockdev(), Markus Armbruster, 2010/06/29