[Qemu-devel] Re: qemu fail to parse command line with "-pcidevice 00:19.0"

[Hidetoshi Seto]

(2010/06/24 15:08), Markus Armbruster wrote:
> Note to qemu-devel: this issue is qemu-kvm only.
> 
> "Hao, Xudong" <address@hidden> writes:
> 
>> When assign one PCI device, qemu fail to parse the command line:
>> qemu-system_x86 -smp 2 -m 1024 -hda /path/to/img -pcidevice host=00:19.0
>> Error:
>> qemu-system-x86_64: Parameter 'id' expects an identifier
>> Identifiers consist of letters, digits, '-', '.', '_', starting with a 
>> letter.
>> pcidevice argument parse error; please check the help text for usage
>> Could not add assigned device host=00:19.0
>>
>> https://bugs.launchpad.net/qemu/+bug/597932
>>
>> This issue caused by qemu-kvm commit 
>> b560a9ab9be06afcbb78b3791ab836dad208a239.
> 
> The bug is in add_assigned_device():
> 
>     r = get_param_value(id, sizeof(id), "id", arg);
>     if (!r)
>         r = get_param_value(id, sizeof(id), "name", arg);
>     if (!r)
>         r = get_param_value(id, sizeof(id), "host", arg);
> 
> We end up with invalid ID "00:19.0".

... Are there any strong reason why we cannot use ':' in the identifier?


Thanks,
H.Seto