[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 02/23] qdev: Restrict direct bus addressing v
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v4 02/23] qdev: Restrict direct bus addressing via its name |
Date: |
Wed, 23 Jun 2010 10:45:17 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Jan Kiszka <address@hidden> writes:
> From: Jan Kiszka <address@hidden>
>
> We allow to address a bus only using its local name. This is ambiguous
> but unfortunately so handy that people (specifically libvirt) will
> likely complain if bus=pci.0 needs to be replaced with
> bus=/i440FX-pcihost/pci.0 all over the place. So keep this for now but
> drop at least support for starting a qtree walks with an abbreviated bus
> name.
>
> Signed-off-by: Jan Kiszka <address@hidden>
Again, affects only -device and device_add option bus.
Before, an argument started either with '/' (path anchored at root) or a
bus name (path anchored at that bus).
Now, an argument started either with '/' (path anchored at root) or it
is a bus name.
If we decide to add sane relative paths to qdev, i.e. paths anchored at
unique ID, we get a slight anomaly here:
bus=a bus name, not a relative path
bus=a/b relative path anchored at node with unique ID a.
Works for me.
- [Qemu-devel] [PATCH v4 04/23] qdev: Allow device addressing via 'driver.instance', (continued)
[Qemu-devel] [PATCH v4 06/23] qdev: Push QMP mode checks into qbus_list_bus/dev, Jan Kiszka, 2010/06/15
[Qemu-devel] [PATCH v4 05/23] qdev: Convert device and bus lists to QTAILQ, Jan Kiszka, 2010/06/15
[Qemu-devel] [PATCH v4 02/23] qdev: Restrict direct bus addressing via its name, Jan Kiszka, 2010/06/15
- Re: [Qemu-devel] [PATCH v4 02/23] qdev: Restrict direct bus addressing via its name,
Markus Armbruster <=
[Qemu-devel] [PATCH v4 08/23] qdev: Introduce qdev_iterate_recursive, Jan Kiszka, 2010/06/15
[Qemu-devel] [PATCH v4 07/23] qdev: Allow device specification by qtree path for device_del, Jan Kiszka, 2010/06/15
[Qemu-devel] [PATCH v4 09/23] monitor: Fix leakage during completion processing, Jan Kiszka, 2010/06/15
[Qemu-devel] [PATCH v4 10/23] monitor: Fix command completion vs. boolean switches, Jan Kiszka, 2010/06/15
[Qemu-devel] [PATCH v4 13/23] monitor: Allow to specify HMP-specifc command arguments, Jan Kiszka, 2010/06/15