qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 02/23] qdev: Restrict direct bus addressing v


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v4 02/23] qdev: Restrict direct bus addressing via its name
Date: Wed, 23 Jun 2010 10:45:17 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)

Jan Kiszka <address@hidden> writes:

> From: Jan Kiszka <address@hidden>
>
> We allow to address a bus only using its local name. This is ambiguous
> but unfortunately so handy that people (specifically libvirt) will
> likely complain if bus=pci.0 needs to be replaced with
> bus=/i440FX-pcihost/pci.0 all over the place. So keep this for now but
> drop at least support for starting a qtree walks with an abbreviated bus
> name.
>
> Signed-off-by: Jan Kiszka <address@hidden>

Again, affects only -device and device_add option bus.

Before, an argument started either with '/' (path anchored at root) or a
bus name (path anchored at that bus).

Now, an argument started either with '/' (path anchored at root) or it
is a bus name.

If we decide to add sane relative paths to qdev, i.e. paths anchored at
unique ID, we get a slight anomaly here:

  bus=a        bus name, not a relative path
  bus=a/b      relative path anchored at node with unique ID a.

Works for me.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]