[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 00/10] pci: pci to pci bridge clean up and enhan
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCH 00/10] pci: pci to pci bridge clean up and enhancement |
Date: |
Fri, 18 Jun 2010 15:46:43 +0300 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Fri, Jun 18, 2010 at 12:26:10PM +0900, Isaku Yamahata wrote:
> On Thu, Jun 17, 2010 at 02:57:16PM +0300, Michael S. Tsirkin wrote:
> > On Thu, Jun 17, 2010 at 01:02:43PM +0300, Michael S. Tsirkin wrote:
> > > For example, forcing all devices to call pci_reset_default
> > > in their reset routines does not look like a good cleanup:
> > > the less boilerplate, the better IMO.
> >
> > One thing that we need to address, is devices
> > which need to enable memory+master on init.
> > They should probably also enable this on reset.
>
> Isn't it BIOS/firmware that initializes those bits?
memory yes, bus master no.
> And seabios does so.
> The pci spec explicitly says that they are 0 after RST#.
Mostly these are bugs in emulation, but could be bugs
in devices that we emulate (PBM).
> > One approach that was discussed several times
> > would be to call cleanup and then init again.
> > I expect this would be enough to get rid of reset
> > callbacks in most devices.
>
> Oh, some devices set those bits on init.
> So cleanup + init again might be easier than
> sorting out initialization/reset of each devices.
Exactly.
> thanks,
> >
> > --
> > MST
> >
>
> --
> yamahata
- [Qemu-devel] Re: [PATCH 09/10] pci: set PCI multi-function bit appropriately., (continued)
- [Qemu-devel] Re: [PATCH 09/10] pci: set PCI multi-function bit appropriately., Michael S. Tsirkin, 2010/06/18
- Re: [Qemu-devel] Re: [PATCH 09/10] pci: set PCI multi-function bit appropriately., Isaku Yamahata, 2010/06/18
- Re: [Qemu-devel] Re: [PATCH 09/10] pci: set PCI multi-function bit appropriately., Michael S. Tsirkin, 2010/06/18
- Re: [Qemu-devel] Re: [PATCH 09/10] pci: set PCI multi-function bit appropriately., Jamie Lokier, 2010/06/18
- Re: [Qemu-devel] Re: [PATCH 09/10] pci: set PCI multi-function bit appropriately., Michael S. Tsirkin, 2010/06/20
[Qemu-devel] [PATCH 10/10] pci: don't overwrite multi functio bit in pci header type., Isaku Yamahata, 2010/06/17
[Qemu-devel] Re: [PATCH 00/10] pci: pci to pci bridge clean up and enhancement, Michael S. Tsirkin, 2010/06/17