[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 20/35] tcg-s390: Use LOAD COMPLIMENT for negate.
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH 20/35] tcg-s390: Use LOAD COMPLIMENT for negate. |
Date: |
Sat, 12 Jun 2010 14:33:36 +0200 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Fri, Jun 04, 2010 at 12:14:28PM -0700, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> tcg/s390/tcg-target.c | 10 ++--------
> 1 files changed, 2 insertions(+), 8 deletions(-)
This patch looks fine.
> diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c
> index f53038b..826a2c8 100644
> --- a/tcg/s390/tcg-target.c
> +++ b/tcg/s390/tcg-target.c
> @@ -1134,16 +1134,10 @@ static inline void tcg_out_op(TCGContext *s,
> TCGOpcode opc,
> break;
>
> case INDEX_op_neg_i32:
> - /* FIXME: optimize args[0] != args[1] case */
> - tcg_out_insn(s, RR, LR, 13, args[1]);
> - tcg_out_movi(s, TCG_TYPE_I32, args[0], 0);
> - tcg_out_insn(s, RR, SR, args[0], 13);
> + tcg_out_insn(s, RR, LCR, args[0], args[1]);
> break;
> case INDEX_op_neg_i64:
> - /* FIXME: optimize args[0] != args[1] case */
> - tcg_out_mov(s, TCG_TMP0, args[1]);
> - tcg_out_movi(s, TCG_TYPE_I64, args[0], 0);
> - tcg_out_insn(s, RRE, SGR, args[0], TCG_TMP0);
> + tcg_out_insn(s, RRE, LCGR, args[0], args[1]);
> break;
>
> case INDEX_op_mul_i32:
> --
> 1.7.0.1
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
- [Qemu-devel] [PATCH 16/35] tcg-s390: Re-implement tcg_out_movi., (continued)
- [Qemu-devel] [PATCH 16/35] tcg-s390: Re-implement tcg_out_movi., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 17/35] tcg-s390: Implement sign and zero-extension operations., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 18/35] tcg-s390: Implement bswap operations., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 19/35] tcg-s390: Implement rotates., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 20/35] tcg-s390: Use LOAD COMPLIMENT for negate., Richard Henderson, 2010/06/04
- Re: [Qemu-devel] [PATCH 20/35] tcg-s390: Use LOAD COMPLIMENT for negate.,
Aurelien Jarno <=
- [Qemu-devel] [PATCH 21/35] tcg-s390: Use the ADD IMMEDIATE instructions., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 22/35] tcg-s390: Use the AND IMMEDIATE instructions., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 23/35] tcg-s390: Use the OR IMMEDIATE instructions., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 24/35] tcg-s390: Use the XOR IMMEDIATE instructions., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 25/35] tcg-s390: Use the MULTIPLY IMMEDIATE instructions., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 26/35] tcg-s390: Tidy goto_tb., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 27/35] tcg-s390: Rearrange qemu_ld/st to avoid register copy., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 28/35] tcg-s390: Tidy tcg_prepare_qemu_ldst., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 29/35] tcg-s390: Tidy user qemu_ld/st., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 30/35] tcg-s390: Implement GUEST_BASE., Richard Henderson, 2010/06/04