[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field |
Date: |
Wed, 9 Jun 2010 03:30:01 +0100 |
User-agent: |
KMail/1.13.3 (Linux/2.6.33-2-amd64; KDE/4.4.3; x86_64; ; ) |
> The offset given to a block created via qemu_ram_alloc/map() is arbitrary,
> let the caller specify a name so we can make a positive match.
> @@ -1924,7 +1925,9 @@ static int pci_add_option_rom(PCIDevice *pdev)
> + snprintf(name, sizeof(name), "pci:%02x.%x.rom",
> + PCI_SLOT(pdev->devfn), PCI_FUNC(pdev->devfn));
> + pdev->rom_offset = qemu_ram_alloc(name, size);
This looks pretty bogus. It should be associated with the device, rather than
incorrectly trying to generate a globally unique name.
Paul
- Re: [Qemu-devel] [RFC PATCH 2/6] ram_blocks: Convert to a QLIST, (continued)
[Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field, Alex Williamson, 2010/06/08
- [Qemu-devel] Re: [RFC PATCH 3/6] RAMBlock: Add a name field, Anthony Liguori, 2010/06/08
- [Qemu-devel] Re: [RFC PATCH 3/6] RAMBlock: Add a name field, Chris Wright, 2010/06/08
- Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field,
Paul Brook <=
- Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field, Anthony Liguori, 2010/06/08
- Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field, Paul Brook, 2010/06/08
- Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field, Alex Williamson, 2010/06/09
- Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field, Paul Brook, 2010/06/09
- Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field, Alex Williamson, 2010/06/09
- Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field, Paul Brook, 2010/06/09
- Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field, Gerd Hoffmann, 2010/06/10
- Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field, Alex Williamson, 2010/06/10
- Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field, Paul Brook, 2010/06/10
- Re: [Qemu-devel] [RFC PATCH 3/6] RAMBlock: Add a name field, Alex Williamson, 2010/06/10