[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 15/22] machine: make max_cpus a -machine option
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] [PATCH 15/22] machine: make max_cpus a -machine option |
Date: |
Tue, 8 Jun 2010 02:01:07 +0100 |
User-agent: |
KMail/1.13.3 (Linux/2.6.33-2-amd64; KDE/4.4.3; x86_64; ; ) |
> diff --git a/hw/realview.c b/hw/realview.c
> index a36bdbe..8dcef80 100644
> --- a/hw/realview.c
> +++ b/hw/realview.c
> @@ -444,9 +444,9 @@ static QEMUMachine realview_eb_mpcore_machine = {
> .init = realview_eb_mpcore_init,
> .opts_default = (QemuOptValue[]) {
> QOPT_VALUE("default_drive", "scsi"),
> + QOPT_VALUE("max_cpus", "4"),
> { /* end of list */ }
> },
> - .max_cpus = 4,
> };
By my reading this allows the user to modify this value. If so it is wrong.
This is a fundamental property/limitation of the hardware. Expect qemu to
crash if the value is modified.
Paul
- Re: [Qemu-devel] [PATCH 10/22] machine: allow boards to specify default values and use it in isapc, (continued)
- [Qemu-devel] [PATCH 05/22] machine: pass all init options as a single QemuOpts, Anthony Liguori, 2010/06/07
- [Qemu-devel] [PATCH 11/22] machine: replace compat_props with opts_default, Anthony Liguori, 2010/06/07
- [Qemu-devel] [PATCH 13/22] machine: get rid of global default QEMUMachine members, Anthony Liguori, 2010/06/07
- [Qemu-devel] [PATCH 12/22] machine: some sugary macros to simplify machine default options, Anthony Liguori, 2010/06/07
- [Qemu-devel] [PATCH 06/22] Make -acpi-enable a machine specific option, Anthony Liguori, 2010/06/07
- [Qemu-devel] [PATCH 17/22] machine: kill machine->alias, Anthony Liguori, 2010/06/07
- [Qemu-devel] [PATCH 16/22] machine: move default machine out of machine definitions, Anthony Liguori, 2010/06/07
- [Qemu-devel] [PATCH 15/22] machine: make max_cpus a -machine option, Anthony Liguori, 2010/06/07
- Re: [Qemu-devel] [PATCH 15/22] machine: make max_cpus a -machine option,
Paul Brook <=
- Re: [Qemu-devel] [PATCH 15/22] machine: make max_cpus a -machine option, Jes Sorensen, 2010/06/09
- [Qemu-devel] [PATCH 19/22] machine: introduce accel option to allow selection of kvm or tcg, Anthony Liguori, 2010/06/07
- [Qemu-devel] [PATCH 21/22] machine: convert pc machines to split core vs machine API, Anthony Liguori, 2010/06/07
- [Qemu-devel] [PATCH 14/22] machine: replace QEMUMachine.use_scsi with -machine default_drive, Anthony Liguori, 2010/06/07
- [Qemu-devel] [PATCH 22/22] machine: introduce -machine-def option to define a machine via config, Anthony Liguori, 2010/06/07