[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/16] clean up vl.c code
|
From: |
Jes Sorensen |
|
Subject: |
Re: [Qemu-devel] [PATCH 00/16] clean up vl.c code |
|
Date: |
Fri, 04 Jun 2010 10:23:43 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Lightning/1.0b2pre Thunderbird/3.0.4 |
On 06/04/10 10:21, Markus Armbruster wrote:
> address@hidden writes:
>> I have tried to be as careful as I can to not break non Linux support,
>> but as I only have a Linux build environment handy, I would appreciate
>> it if people with other OSes could check that I didn't break anything
>> for them. In particular I would like to know if win32 still builds.
>
> I like moving stuff out of vl.c in general. Your moves of entire
> functions look like a win to me. I have doubts about spreading the
> option switch over three files, though.
The problem is right now there are too many OS specific options, but
having the #ifdefs plastered all over to enable/disable them accordingly
is just a nightmare and is prone to leave in inconsistent behavior for
various OSes. See the set_proc_name() stuff for an example.
Cheers,
Jes
- Re: [Qemu-devel] [PATCH 10/16] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c, (continued)
[Qemu-devel] [PATCH 13/16] Move daemonize handling to OS specific files, Jes . Sorensen, 2010/06/03
[Qemu-devel] [PATCH 15/16] Move line-buffering setup to OS specific files., Jes . Sorensen, 2010/06/03
[Qemu-devel] [PATCH 16/16] Move set_proc_name() to OS specific files., Jes . Sorensen, 2010/06/03
Re: [Qemu-devel] [PATCH 00/16] clean up vl.c code, Markus Armbruster, 2010/06/04
- Re: [Qemu-devel] [PATCH 00/16] clean up vl.c code,
Jes Sorensen <=