[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] give some useful error messages when tap open
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] give some useful error messages when tap open |
Date: |
Wed, 02 Jun 2010 20:26:58 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Luiz Capitulino <address@hidden> writes:
> From: Michael Tokarev <address@hidden>
>
> In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints
> (with fprintf) something like this:
>
> warning: could not open /dev/net/tun: no virtual network emulation
>
> this has 2 issues:
> 1) it is not a warning really, it's a fatal error (kvm exits after
> that),
> 2) there's no indication as of what's actually wrong: printing errno there
> is helpful.
>
> The patch below removes the "warning" prefix, uses %m (since it's linux,
> %m is available as format modifier), and changes fprintf() to %qemu_error().
To error_report(), you mean.
> Now it prints something like this instead:
>
> could not configure /dev/net/tun: Device or resource busy
>
> (there are 2 messages like that in the same function)
>
> This fixes Debian bug #578154, see
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=578154
>
> Signed-off-by: Michael Tokarev <address@hidden>
> Signed-off-by: Luiz Capitulino <address@hidden>
Looks good.