qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] hw/serial.c: Xmit fifo never used


From: Paul Brook
Subject: Re: [Qemu-devel] hw/serial.c: Xmit fifo never used
Date: Fri, 28 May 2010 15:31:26 +0100
User-agent: KMail/1.13.3 (Linux/2.6.33-2-amd64; KDE/4.4.3; x86_64; ; )

> The problem is that this path is never used as tsr_retry is never > 0
> initially. So if qemu_chr_write() fails, we never try again but drop

qemu_chr_write is a blocking interface. It should only fail if an 
unrecoverable error occurs. In that case there's noting useful we can do, and 
no reason to retry.

Paul



reply via email to

[Prev in Thread] Current Thread [Next in Thread]