Re: [Qemu-devel] [PATCH] posix-aio-compat: Expand tabs that have crept in

[Kevin Wolf]

Am 27.05.2010 15:12, schrieb Stefan Hajnoczi:
> On Thu, May 27, 2010 at 02:50:54PM +0200, Kevin Wolf wrote:
>> I'm usually not a big supporter of patches that only change style, but
>> tabs are nasty and you can ignore these whitespace changes in git blame
>> at least, so for all I care let's take it for once.
> 
> Interesting, I tend to prefer separate code change and whitespace change
> patches.  It's hard to review a patch that combines code and whitespace
> changes because you have to manually compare the touched lines to see
> what, if anything, has changed.

That's not what I mean either. I usually avoid any style fixes in code
that I don't touch otherwise. So when I need to fix an if condition
anyway, I can add missing braces there as well, but I wouldn't write a
patch that adds braces everywhere.

The main reason is that it would break git blame output by listing some
completely unrelated style fixes instead of the patch that really added
or semantically changed the line. Whitespace changes are not quite as
bad, though, as there is git blame -w.

> Is this the policy across all of QEMU or your preference for
> block-related code?  I'll try to follow it for that area in the future.

I don't think it's written down explicitly, but I remember some
discussion about style fixes which basically resulted in "do new code
right, leave old code alone".

Kevin