[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 4/5] vnc: don't send invalid screen updates.
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PATCH 4/5] vnc: don't send invalid screen updates. |
Date: |
Tue, 25 May 2010 18:25:19 +0200 |
Don't send updates for screen areas which are outside the clients
desktop. May happed with vnc clients which don't support the desktop
resize message.
Signed-off-by: Gerd Hoffmann <address@hidden>
---
vnc.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/vnc.c b/vnc.c
index 30e0bed..119ffe8 100644
--- a/vnc.c
+++ b/vnc.c
@@ -836,6 +836,7 @@ static int vnc_update_client(VncState *vs, int has_dirty)
int y;
int n_rectangles;
int saved_offset;
+ int width, height;
if (vs->output.offset && !vs->audio_cap && !vs->force_update)
/* kernel send buffers are full -> drop frames to throttle */
@@ -856,10 +857,13 @@ static int vnc_update_client(VncState *vs, int has_dirty)
saved_offset = vs->output.offset;
vnc_write_u16(vs, 0);
- for (y = 0; y < vd->server->height; y++) {
+ width = MIN(vd->server->width, vs->client_width);
+ height = MIN(vd->server->height, vs->client_height);
+
+ for (y = 0; y < height; y++) {
int x;
int last_x = -1;
- for (x = 0; x < vd->server->width / 16; x++) {
+ for (x = 0; x < width / 16; x++) {
if (vnc_get_bit(vs->dirty[y], x)) {
if (last_x == -1) {
last_x = x;
--
1.6.6.1
- [Qemu-devel] [PATCH 0/5] vnc: desktop size patches., Gerd Hoffmann, 2010/05/25
- [Qemu-devel] [PATCH 2/5] vnc: send desktopresize event as reply to set encodings, Gerd Hoffmann, 2010/05/25
- [Qemu-devel] [PATCH 1/5] vnc: factor out vnc_desktop_resize(), Gerd Hoffmann, 2010/05/25
- [Qemu-devel] [PATCH 4/5] vnc: don't send invalid screen updates.,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH 3/5] vnc: keep track of client desktop size, Gerd Hoffmann, 2010/05/25
- [Qemu-devel] [PATCH 5/5] vnc: move size-changed check into the vnc_desktop_resize function., Gerd Hoffmann, 2010/05/25
- Re: [Qemu-devel] [PATCH 0/5] vnc: desktop size patches., Daniel P. Berrange, 2010/05/26