qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] ioport: add function to check whenever a po


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 1/2] ioport: add function to check whenever a port is assigned or not
Date: Tue, 25 May 2010 11:41:29 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Thunderbird/3.0.4

On 05/24/10 14:32, Paul Brook wrote:
+int is_ioport_assigned(pio_addr_t addr)

Shouldn't we move this into register_ioport_{read,write}, and have that fail
if the port has already been assigned?

It already checks and fails with hw_error(). Problem with that is that this kills qemu in case you try to pci hot-plug a vga card. So I've added a way to check before-hand, so we can fail gracefully in the few places where we need it (see second patch of the series).

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]