qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH] sdl: fix setenv for win32


From: Jan Kiszka
Subject: [Qemu-devel] Re: [PATCH] sdl: fix setenv for win32
Date: Tue, 25 May 2010 08:20:21 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666

TeLeMan wrote:
> setenv() is not implemented on MinGW, so we have to use putenv().

What a ... pity.

> 
> Signed-off-by: TeLeMan <address@hidden>
> ---
>  sdl.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/sdl.c b/sdl.c
> index add1148..eb4a87f 100644
> --- a/sdl.c
> +++ b/sdl.c
> @@ -850,7 +850,11 @@ void sdl_display_init(DisplayState *ds, int
> full_screen, int no_frame)
>          gui_noframe = 1;
> 
>      if (!full_screen) {
> +#ifdef _WIN32
> +        putenv("SDL_VIDEO_ALLOW_SCREENSAVER=1");

This is not equivalent, the user will no longer be able to control the
value by setting it before starting qemu.

Let's check for the existence of SDL_VIDEO_ALLOW_SCREENSAVER first, set
it if it's not yet there, and do this for all platforms, leaving a
comment about the WIN32 dependency behind.

Jan

> +#else
>          setenv("SDL_VIDEO_ALLOW_SCREENSAVER", "1", 0);
> +#endif
>      }
> 
>      flags = SDL_INIT_VIDEO | SDL_INIT_NOPARACHUTE;


Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]