Re: [Qemu-devel] [PATCH 19/22] tcg-i386: Tidy xchg.

[Aurelien Jarno]

On Wed, Apr 14, 2010 at 11:32:24AM -0700, Richard Henderson wrote:
> Define and use OPC_XCHG_ax_r32.
> 
> Signed-off-by: Richard Henderson <address@hidden>

Acked-by: Aurelien Jarno <address@hidden>

> ---
>  tcg/i386/tcg-target.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c
> index 020faf0..bf3c0d6 100644
> --- a/tcg/i386/tcg-target.c
> +++ b/tcg/i386/tcg-target.c
> @@ -197,6 +197,7 @@ static inline int tcg_target_const_match(tcg_target_long 
> val,
>  #define OPC_SHIFT_Ib (0xc1)
>  #define OPC_SHIFT_cl (0xd3)
>  #define OPC_TESTL    (0x85)
> +#define OPC_XCHG_ax_r32      (0x90)
>  
>  #define OPC_GRP3_Ev  (0xf7)
>  #define OPC_GRP5     (0xff)
> @@ -793,7 +794,8 @@ static void tcg_out_qemu_ld(TCGContext *s, const TCGArg 
> *args,
>          break;
>      case 3:
>          if (data_reg == TCG_REG_EDX) {
> -            tcg_out_opc(s, 0x90 + TCG_REG_EDX); /* xchg %edx, %eax */
> +            /* xchg %edx, %eax */
> +            tcg_out_opc(s, OPC_XCHG_ax_r32 + TCG_REG_EDX);
>              tcg_out_mov(s, data_reg2, TCG_REG_EAX);
>          } else {
>              tcg_out_mov(s, data_reg, TCG_REG_EAX);
> -- 
> 1.6.6.1
> 
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net