qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_c


From: Michael Tokarev
Subject: [Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare
Date: Wed, 19 May 2010 23:42:40 +0400
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.1.9) Gecko/20100411 Icedove/3.0.4

19.05.2010 23:38, Christoph Hellwig wrote:
On Wed, May 19, 2010 at 11:26:58PM +0400, Michael Tokarev wrote:
Now the question is if the previous patch by Avi is actually
worth to apply -- I mean this one:
  [Qemu-devel] [PATCH +stable] block: don't attempt to merge overlapping
  requests

No, that was just a hack, it shouldn't be applied.

Actually it's not that obvious.  If the actual problem
here (besides the mis-comparison) is due to missing
barriers or flushes.  Avi asked a good question in that
thread.

But I'm hijacking the thread actually :)

/mjt




reply via email to

[Prev in Thread] Current Thread [Next in Thread]