Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

[Avi Kivity]

On 05/14/2010 08:03 PM, Markus Armbruster wrote:
> Avi Kivity<address@hidden>  writes:
>
>    
> > On 05/14/2010 11:50 AM, Markus Armbruster wrote:
> >      
> > >        
> > > > > +
> > > > > +{ "execute": "migrate_set_speed", "arguments": { "value": 1024 } }
> > > > >
> > > > >
> > > > >            
> > > > Oh, we do have more.
> > > >
> > > > Please document the units for this value (bits per second)?
> > > >
> > > >          
> > > bytes per second?
> > >
> > >        
> > Bandwidth is typically measured in bits per second.
> >      
> The question is what unit the code actually uses.  What it should use is
> separate, if valid question.
>    

Right.

> > > We have a list of buses, each containing a list of device functions.
> > > Not sure the additional level of nesting you propose buys us anything.
> > >
> > >        
> > A slot is the hotpluggable entity.  Open your computer and you can
> > actually see them.
> >      
> QEMU doesn't really know that.
>    

How can that be?  Do we signal hotplug notifications to a function or to 
a slot?

Can we hotplug a single function in an already occupied slot?

> > btw would be good to list empty slots as well.
> >      
> Why?
>    

So management knows how many slots are available.

It's the difference between:

   Error: the device could not be hotplugged

and

<button disabled="yes">Hotplug device</button>

  or

  3 PCI slots free.

--
Do not meddle in the internals of kernels, for they are subtle and quick to 
panic.