[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'
From: |
Jes Sorensen |
Subject: |
[Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...' |
Date: |
Wed, 12 May 2010 22:38:53 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.4 |
On 05/12/10 22:29, Cole Robinson wrote:
> Commit f75ca1ae205f24dae296c82d534c37746f87232f changed the version
> string from:
>
> QEMU PC Emulator version x.yy.z
>
> to
>
> QEMU Emulator version x.yy.z
>
> libvirt is overly sensitive to the format of this string, and barfs when
> trying to parse qemu -help output. While libvirt should certainly be more
> robust here, changing the output format of -version for cosmetic reasons
> doesn't seem like the best idea, so let's revert the change and add a
> comment explaining the issue.
Rather than this, I would prefer a -version argument that just returns
the current QEMU version string.
IMHO it's not a good approach to do static string matching.
Cheers,
Jes
- [Qemu-devel] [PATCH] Revive -version 'QEMU PC Emulator...', Cole Robinson, 2010/05/12
- [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...',
Jes Sorensen <=
- [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...', Cole Robinson, 2010/05/12
- [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...', Jes Sorensen, 2010/05/13
- [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...', Cole Robinson, 2010/05/13
- [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...', Jes Sorensen, 2010/05/13
- Re: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...', Daniel P. Berrange, 2010/05/13
- Re: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...', Luiz Capitulino, 2010/05/13
- Re: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...', Paul Brook, 2010/05/13
- Re: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...', Blue Swirl, 2010/05/13
- Re: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...', Stuart Brady, 2010/05/13
- [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...', Anthony Liguori, 2010/05/14