[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read
From: |
Alexander Graf |
Subject: |
[Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read |
Date: |
Tue, 11 May 2010 18:35:08 +0200 |
User-agent: |
Thunderbird 2.0.0.23 (X11/20090817) |
Jan Kiszka wrote:
> Alexander Graf wrote:
>
>> Jan Kiszka wrote:
>>
>>> Move the buffer flush from mux_chr_read to mux_chr_can_read. While the
>>> latter is called periodically, the former will only be invoked when new
>>> characters arrive at the back-end. This caused problems to front-end
>>> drivers whenever they were unable to read data immediately, e.g.
>>> virtio-console attached to stdio.
>>>
>>>
>> I don't see this patch applied, but also don't see any issues with
>> virtio-console anymore on today's git. Odd.
>>
>>
>
> Hmm, I had a clear before-after experience using virtio console with an
> x86 Linux guest. I still think my patch is correct and required. Maybe
> you can bisect this positive "regression"? Something might paper over
> the core issue now.
>
I just did a git reset --hard on
baf0b55a9e57b909b1f8b0f732c0b10242867418 and it worked! What the ...
Alex
- Re: [Qemu-devel] [PATCH] [RESEND] Make char muxer more robust wrt small FIFOs, (continued)
- Re: [Qemu-devel] [PATCH] [RESEND] Make char muxer more robust wrt small FIFOs, Anthony Liguori, 2010/05/04
- Re: [Qemu-devel] [PATCH] [RESEND] Make char muxer more robust wrt small FIFOs, Alexander Graf, 2010/05/04
- Re: [Qemu-devel] [PATCH] [RESEND] Make char muxer more robust wrt small FIFOs, Anthony Liguori, 2010/05/04
- Re: [Qemu-devel] [PATCH] [RESEND] Make char muxer more robust wrt small FIFOs, Jan Kiszka, 2010/05/04
- [Qemu-devel] Re: [PATCH] [RESEND] Make char muxer more robust wrt small FIFOs, Jan Kiszka, 2010/05/05
- [Qemu-devel] Re: [PATCH] [RESEND] Make char muxer more robust wrt small FIFOs, Jan Kiszka, 2010/05/05
- [Qemu-devel] Re: [PATCH] [RESEND] Make char muxer more robust wrt small FIFOs, Alexander Graf, 2010/05/05
- [Qemu-devel] [PATCH] char: Flush read buffer in mux_chr_can_read, Jan Kiszka, 2010/05/05
- [Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read, Alexander Graf, 2010/05/11
- [Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read, Jan Kiszka, 2010/05/11
- [Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read,
Alexander Graf <=
- [Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read, Jan Kiszka, 2010/05/12
- [Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read, Alexander Graf, 2010/05/14
- [Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read, Jan Kiszka, 2010/05/14
- [Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read, Alexander Graf, 2010/05/15
- [Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read, Jan Kiszka, 2010/05/15
- [Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read, Alexander Graf, 2010/05/15
- [Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read, Jan Kiszka, 2010/05/15