[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Patch to improve handling of server sockets
From: |
Reinhard Max |
Subject: |
Re: [Qemu-devel] Patch to improve handling of server sockets |
Date: |
Wed, 5 May 2010 19:44:52 +0200 (CEST) |
User-agent: |
Alpine 2.00 (LNX 1167 2008-08-23) |
Hi,
I've attached a revised version of the patch against git as of this
morning.
It has even more FIXMEs in it than the previous version, because of
the changes that went into QEMU since 0.11.0 and I think I'll have to
leave those to you guys who are more familiar with QEMUs internals
than I am, but I hope my pactch can serve as a starting point getting
the socket handling in QEMU more correct and flexible.
On Wed, 5 May 2010 at 09:29, Daniel P. Berrange wrote:
The approach looks reasonable, though the patch is somewhat mangled
by the mix of tabs + spaces
Well, that's what XEmacs gives me by default. ;)
How about adding magic comments for vim and emacs to the source files
that bring the editors in line with the project's coding style to make
it easier for new contributors to follow the style?
BTW, while converting the tabs to spaces in my changes, I found that
there are also quite a few tabs in the code already.
cu
Reinhard
qemu-multisocket.patch
Description: Text Data
- Re: [Qemu-devel] Patch to improve handling of server sockets, (continued)
- Re: [Qemu-devel] Patch to improve handling of server sockets, Gerd Hoffmann, 2010/05/04
- Re: [Qemu-devel] Patch to improve handling of server sockets, Reinhard Max, 2010/05/04
- Re: [Qemu-devel] Patch to improve handling of server sockets, Gerd Hoffmann, 2010/05/05
- Re: [Qemu-devel] Patch to improve handling of server sockets, Reinhard Max, 2010/05/05
- Re: [Qemu-devel] Patch to improve handling of server sockets, Gerd Hoffmann, 2010/05/05
- Re: [Qemu-devel] Patch to improve handling of server sockets, Daniel P. Berrange, 2010/05/05
Re: [Qemu-devel] Patch to improve handling of server sockets, Daniel P. Berrange, 2010/05/05
- Re: [Qemu-devel] Patch to improve handling of server sockets,
Reinhard Max <=