|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH] Fix qemu mouse Set_Protocol behavior |
Date: | Mon, 03 May 2010 12:02:01 -0500 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0 |
On 05/01/2010 09:38 PM, Kevin O'Connor wrote:
The QEMU USB mouse claims to support the "boot" protocol (bInterfaceSubClass is 1). However, the mouse rejects the Set_Protocol command. The qemu mouse does support the "boot" protocol specification, so a simple fix is to just enable the Set_Portocol request. -Kevin
Could you included a Signed-of-by: and resubmit both patches? Thanks, Anthony Liguori
--- a/hw/usb-hid.c +++ b/hw/usb-hid.c @@ -790,13 +790,13 @@ static int usb_hid_handle_control(USBDevice *dev, int request, int value, goto fail; break; case GET_PROTOCOL: - if (s->kind != USB_KEYBOARD) + if (s->kind != USB_KEYBOARD&& s->kind != USB_MOUSE) goto fail; ret = 1; data[0] = s->protocol; break; case SET_PROTOCOL: - if (s->kind != USB_KEYBOARD) + if (s->kind != USB_KEYBOARD&& s->kind != USB_MOUSE) goto fail; ret = 0; s->protocol = value;
[Prev in Thread] | Current Thread | [Next in Thread] |