[Qemu-devel] [PATCH 16/22] tcg-i386: Tidy setcc.

[Richard Henderson]

Define and use OPC_SETCC.

Signed-off-by: Richard Henderson <address@hidden>
---
 tcg/i386/tcg-target.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c
index 27e9e9e..0c1a53a 100644
--- a/tcg/i386/tcg-target.c
+++ b/tcg/i386/tcg-target.c
@@ -189,6 +189,7 @@ static inline int tcg_target_const_match(tcg_target_long 
val,
 #define OPC_PUSH_Iv    (0x68)
 #define OPC_PUSH_Ib    (0x6a)
 #define OPC_RET                (0xc3)
+#define OPC_SETCC      (0x90 | P_EXT)  /* ... plus condition code */
 #define OPC_SHIFT_1    (0xd1)
 #define OPC_SHIFT_Ib   (0xc1)
 #define OPC_SHIFT_cl   (0xd3)
@@ -600,8 +601,7 @@ static void tcg_out_setcond(TCGContext *s, TCGCond cond, 
TCGArg dest,
                             TCGArg arg1, TCGArg arg2, int const_arg2)
 {
     tcg_out_cmp(s, arg1, arg2, const_arg2);
-    /* setcc */
-    tcg_out_modrm(s, 0x90 | tcg_cond_to_jcc[cond] | P_EXT, 0, dest);
+    tcg_out_modrm(s, OPC_SETCC | tcg_cond_to_jcc[cond], 0, dest);
     tcg_out_ext8u(s, dest, dest);
 }
 
-- 
1.6.6.1