[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH 06/10] kvm: remove explicit kvm_arch_reset_v
From: |
Marcelo Tosatti |
Subject: |
Re: [Qemu-devel] Re: [PATCH 06/10] kvm: remove explicit kvm_arch_reset_vcpu from kvm_init_vcpu |
Date: |
Wed, 28 Apr 2010 13:42:01 -0300 |
User-agent: |
Mutt/1.5.20 (2009-08-17) |
On Wed, Apr 28, 2010 at 01:22:14PM -0300, Marcelo Tosatti wrote:
> On Wed, Apr 28, 2010 at 10:39:06AM -0500, Anthony Liguori wrote:
> > On 04/26/2010 12:59 PM, Marcelo Tosatti wrote:
> > >This is now done via the initialization's qemu_system_reset call.
> > >
> > >Signed-off-by: Avi Kivity<address@hidden>
> > >---
> > > kvm-all.c | 1 -
> > > 1 files changed, 0 insertions(+), 1 deletions(-)
> > >
> > >diff --git a/kvm-all.c b/kvm-all.c
> > >index 9c8aa7d..eabb097 100644
> > >--- a/kvm-all.c
> > >+++ b/kvm-all.c
> > >@@ -208,7 +208,6 @@ int kvm_init_vcpu(CPUState *env)
> > > ret = kvm_arch_init_vcpu(env);
> > > if (ret == 0) {
> > > qemu_register_reset(kvm_reset_vcpu, env);
> > >- kvm_arch_reset_vcpu(env);
> > > }
> > > err:
> > > return ret;
> >
> > This breaks -enable-kvm in upstream qemu. No progress is ever made
> > in the guest.
>
> These patches have been autotested, and just confirmed manually that
> this patch does not break -enable-kvm (as the reset handler is now
> called through the notifier).
>
> What is your qemu command line?
Just drop it please.
[Qemu-devel] [PATCH 03/10] kvm: handle internal error, Marcelo Tosatti, 2010/04/26
[Qemu-devel] [PATCH 05/10] kvm_init_vcpu requires global lock held, Marcelo Tosatti, 2010/04/26
[Qemu-devel] [PATCH 04/10] kvm: allow qemu to set EPT identity mapping address, Marcelo Tosatti, 2010/04/26
[Qemu-devel] [PATCH 08/10] introduce leul_to_cpu, Marcelo Tosatti, 2010/04/26
[Qemu-devel] [PATCH 10/10] introduce qemu_ram_map, Marcelo Tosatti, 2010/04/26