[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v6 05/18] virtio-serial: Use control messages to
From: |
Amit Shah |
Subject: |
[Qemu-devel] Re: [PATCH v6 05/18] virtio-serial: Use control messages to notify guest of new ports |
Date: |
Wed, 28 Apr 2010 09:57:49 +0530 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On (Tue) Apr 27 2010 [12:37:00], Anthony Liguori wrote:
> On 04/27/2010 07:33 AM, Amit Shah wrote:
>> Allow the port 'id's to be set by a user on the command line. This is
>> needed by management apps that will want a stable port numbering scheme
>> for hot-plug/unplug and migration.
>>
>> Since the port numbers are shared with the guest (to identify ports in
>> control messages), we just send a control message to the guest
>> indicating addition of new ports (hot-plug) or notifying the guest of
>> the available ports when the guest sends us a DEVICE_READY control
>> message.
>>
>> Signed-off-by: Amit Shah<address@hidden>
>>
>
> If you're introducing a new message type, don't you need to negotiate
> that feature with the guest?
Since we didn't have any kernel or qemu released with the older ABI,
changing the numbers isn't a bad thing (we disabled multiport support
for 2.6.34 because of this).
Amit
- [Qemu-devel] [PATCH v6 16/18] virtio-serial: Discard data that guest sends us when ports aren't connected, (continued)
- [Qemu-devel] [PATCH v6 16/18] virtio-serial: Discard data that guest sends us when ports aren't connected, Amit Shah, 2010/04/27
- [Qemu-devel] [PATCH v6 17/18] virtio-serial: Implement flow control for individual ports, Amit Shah, 2010/04/27
- [Qemu-devel] [PATCH v6 18/18] virtio-serial-bus: wake up iothread upon guest read notification, Amit Shah, 2010/04/27
- [Qemu-devel] Re: [PATCH v6 18/18] virtio-serial-bus: wake up iothread upon guest read notification, Anthony Liguori, 2010/04/27
- [Qemu-devel] Re: [PATCH v6 18/18] virtio-serial-bus: wake up iothread upon guest read notification, Marcelo Tosatti, 2010/04/27
- [Qemu-devel] Re: [PATCH v6 18/18] virtio-serial-bus: wake up iothread upon guest read notification, Anthony Liguori, 2010/04/27
- [Qemu-devel] Re: [PATCH v6 18/18] virtio-serial-bus: wake up iothread upon guest read notification, Amit Shah, 2010/04/28
- [Qemu-devel] Re: [PATCH v6 18/18] virtio-serial-bus: wake up iothread upon guest read notification, Anthony Liguori, 2010/04/28
- [Qemu-devel] Re: [PATCH v6 18/18] virtio-serial-bus: wake up iothread upon guest read notification, Amit Shah, 2010/04/28
- [Qemu-devel] Re: [PATCH v6 05/18] virtio-serial: Use control messages to notify guest of new ports, Anthony Liguori, 2010/04/27
- [Qemu-devel] Re: [PATCH v6 05/18] virtio-serial: Use control messages to notify guest of new ports,
Amit Shah <=
- [Qemu-devel] Re: [PATCH v6 05/18] virtio-serial: Use control messages to notify guest of new ports, Anthony Liguori, 2010/04/28
[Qemu-devel] Re: [PATCH v6 01/18] virtio-serial: save/load: Ensure target has enough ports, Anthony Liguori, 2010/04/28