[Qemu-devel] Re: [PATCH] win32: Avoid compiler warning (WIN32_LEAN_AND_MEAN redefined)

[Paolo Bonzini]

On 04/21/2010 10:13 PM, Stefan Weil wrote:
> Stefan Weil schrieb:
> > configure adds the macro WIN32_LEAN_AND_MEAN to
> > QEMU_CFLAGS, and SDL_syswm.h defines it, too.
> >
> > This results in a compiler warning (redefinition of
> > WIN32_LEAN_AND_MEAN in SDL_syswm.h. That warning prevents
> > compilations for win32 with warning = error).
> >
> > Fix this by removing the definition of WIN32_LEAN_AND_MEAN
> > before including SDL_syswm.h.
>>
> > +/* Avoid compiler warning because macro is redefined in SDL_syswm.h. */
> > +#undef WIN32_LEAN_AND_MEAN
> > +
> > #include<SDL.h>
> > #include<SDL_syswm.h>
>
> No comments, no questions? The original patch still applies.

Why does that conflict?  If the redefinition is with the same meaning, 
GCC should not conflict.

There is

#define WIN32_LEAN_AND_MEAN

in SDL_syswm.h and -DWIN32_LEAN_AND_MEAN in configure, so that should be 
okay.

Paolo