Re: [Qemu-devel] [PATCH] fix curses update

[andrzej zaborowski]

Hi,

On 20 April 2010 11:38, Bernhard Kauer <address@hidden> wrote:
> If a terminal is resized or the VGA model issues a full refresh, 
> curses_update()
> is called, which uses mvwaddchnstr() to draw a full line of characters.  
> Unfortunatelly
> this routine expects a null-terminated string and early aborts if a null is 
> present
> in the line.
>
> When booting an OS that zeros the VGA text buffer and later pokes single 
> characters,
> the console output can become unreadable.  The attached patch corrects this 
> bug.

I believe this issue has come up before with a similar patch but
someone checked their ncurses and they didn't see the same issue.  I
just checked and here mvwaddchnstr() does not expect a null-terminated
string either, but it skips the \0 characters.  So probably we should
replace them with spaces or something else,  I wouldn't like to
replace a single library call with 80 calls, it's better to go through
the string and replace them, maybe in console_write_ch or somewhere
else.

Cheers