Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG

[Ian Molton]

Jamie Lokier wrote:

> But enough of that: It's history now; the guest virtio-rng has existed
> for more than a year.  It is also amazingly short and simple.  Yay for Rusty!

Ok, so...

If we can now take steps to integrate the code...

I'd like to get some feedback (or merging!) of the other parts of the
patch, namely:-

* the SIZE property patch:    Msg-Id: <address@hidden>
* the socket reconnect patch: Msg-Id: <address@hidden>

If we can get these patches sorted out, the only outstanding issues are
where the EGD protocol support and rate limiting should go.

IMO, both are so small and simple that I'd leave them in the driver,
however I'm open to (realistic) suggestions on how else to go about
this. AIUI qemus chardev layer doesnt 'do' line disciplines, which
complicates matters.

For reference, the EGD protocol is implemented in 5 lines of code, and
rate limiting in about 10.

I don't mind changing qemu_gettimeofday for some other counter (does
qemu provide a monotonic counter (from the hosts perspective) of some
sort?) - if anyone is /really/ bothered by the fact that one buffer fill
could happen at 2x the set rate should the timeofday be glitched.

:-D

-Ian