[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH][STABLE] Add qerror message if the 'change' targ
From: |
Ryan Harper |
Subject: |
Re: [Qemu-devel] [PATCH][STABLE] Add qerror message if the 'change' target filename can't be opened |
Date: |
Sun, 18 Apr 2010 21:37:18 -0500 |
User-agent: |
Mutt/1.5.6+20040907i |
* Aurelien Jarno <address@hidden> [2010-04-18 15:55]:
> On Fri, Apr 09, 2010 at 07:46:38AM -0500, Ryan Harper wrote:
> > Currently when using the change command to switch the file in the cd drive
> > the command doesn't complain if the file doesn't exit or can't be opened
> > and the drive keeps the existing image. This patch adds a qerror_report
> > call to print a message out indicating the failure. This error message
> > can be used to catch failures.
>
> Applied to HEAD, however it doesn't apply to stable. Is it really needed
> here?
No, you're right. Qemu doesnt' segfault or anything bad. That and the
qerror class for open file failed isn't in stable so we'd have to pull
that new code in (it's small, like 7 lines. Anyhow, I have the patches,
but I agree that they aren't necessary for stable.
--
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
address@hidden