[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] virtio-console: Notify resize to the guest.
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] virtio-console: Notify resize to the guest. |
Date: |
Fri, 16 Apr 2010 18:32:19 +0530 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On (Fri) Apr 16 2010 [20:42:47], Kusanagi Kouichi wrote:
>
> Signed-off-by: Kusanagi Kouichi <address@hidden>
> ---
> hw/virtio-console.c | 3 +++
> hw/virtio-serial-bus.c | 8 ++++++++
> hw/virtio-serial.h | 9 +++++++--
> 3 files changed, 18 insertions(+), 2 deletions(-)
Hello,
The patches look good. How did you test them?
Just one comment here:
> diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
> index 17c1ec1..66891ee 100644
> --- a/hw/virtio-serial-bus.c
> +++ b/hw/virtio-serial-bus.c
> @@ -163,6 +163,13 @@ int virtio_serial_close(VirtIOSerialPort *port)
> return 0;
> }
>
> +void virtio_serial_resize(VirtIOSerialPort *port, int rows, int cols)
Would virtio_serial_resize_console() be better, since this is only to be
used for console ports?
Amit
- [Qemu-devel] [PATCH 2/2] virtio-console: Notify resize to the guest., Kusanagi Kouichi, 2010/04/16
- Re: [Qemu-devel] [PATCH 2/2] virtio-console: Notify resize to the guest.,
Amit Shah <=
- Re: [Qemu-devel] [PATCH 2/2] virtio-console: Notify resize to the guest., Kusanagi Kouichi, 2010/04/29
- Re: [Qemu-devel] [PATCH 2/2] virtio-console: Notify resize to the guest., Amit Shah, 2010/04/29
- Re: [Qemu-devel] [PATCH 2/2] virtio-console: Notify resize to the guest., Kusanagi Kouichi, 2010/04/29
- Re: [Qemu-devel] [PATCH 2/2] virtio-console: Notify resize to the guest., Amit Shah, 2010/04/29
- [Qemu-devel] [PATCH v2 2/2] virtio-console: Notify resize to the guest., Kusanagi Kouichi, 2010/04/30
- [Qemu-devel] Re: [PATCH v2 2/2] virtio-console: Notify resize to the guest., Amit Shah, 2010/04/30