Re: [Qemu-devel] [PATCH 06/18] tcg/arm: add defines for the allowed instructions set

[Paul Brook]

> Use a set of #define to define the allowed ARM instructions, depending
> on the __ARM_ARCH_*__ GCC defines.
> 
> Signed-off-by: Aurelien Jarno <address@hidden>
> ---
>  tcg/arm/tcg-target.c |   27 ++++++++++++++++++++++++---
>  1 files changed, 24 insertions(+), 3 deletions(-)
> 
> diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c
> index ee5f723..cae6385 100644
> --- a/tcg/arm/tcg-target.c
> +++ b/tcg/arm/tcg-target.c
> @@ -22,6 +22,27 @@
>   * THE SOFTWARE.
>   */
> 
> +#if defined(__ARM_ARCH_5T__) || \
> +    defined(__ARM_ARCH_5TE__) || \
> +    defined(__ARM_ARCH_5TEJ__) || \
> +    defined(__ARM_ARCH_6__) || \
> +    defined(__ARM_ARCH_7A__) || \
> +    defined(__ARM_ARCH_7__)
> +# define USE_ARMV5_INSTRUCTIONS 1
> +#endif

Would be better to avoid redundancy by reordering a bit and doing:

#if defined(__ARM_ARCH_5T__) || \
    defined(__ARM_ARCH_5TE__) || \
    defined(__ARM_ARCH_5TEJ__) || \
    defined(USE_ARMV6_INSTRUCTIONS)

> +#if defined(__ARM_ARCH_6__) || \
> +    defined(__ARM_ARCH_7A__) || \
> +    defined(__ARM_ARCH_7__)
> +# define USE_ARMV6_INSTRUCTIONS 1
> +#endif

Likewise.

> +#if defined(__ARM_ARCH_7A__) || \
> +    defined(__ARM_ARCH_7__)
> +# define USE_ARMV7_INSTRUCTIONS 1
> +#endif

Missing check for __ARM_ARCH_7R__. Should probably also check 7M and 7EM, even 
though we don't currently generate Thumb code.

Paul