[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 5/8] char: Let writers know how much data was writte
From: |
Amit Shah |
Subject: |
[Qemu-devel] [PATCH 5/8] char: Let writers know how much data was written in case of errors |
Date: |
Thu, 8 Apr 2010 02:32:33 +0530 |
On writing errors, we just returned -1 even if some bytes were already
written out. Ensure we return the number of bytes written before we
return the error (on a subsequent call to qemu_chr_write()).
Signed-off-by: Amit Shah <address@hidden>
---
qemu-char.c | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 048da3f..208466f 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -502,8 +502,13 @@ static int unix_write(int fd, const uint8_t *buf, int len1)
while (len > 0) {
ret = write(fd, buf, len);
if (ret < 0) {
- if (errno != EINTR && errno != EAGAIN)
- return -1;
+ if (errno != EINTR && errno != EAGAIN) {
+ if (len1 - len) {
+ return len1 - len;
+ } else {
+ return -1;
+ }
+ }
} else if (ret == 0) {
break;
} else {
--
1.6.2.5
- [Qemu-devel] [PATCH 0/8] (v2) chardev, virtio-console: flow control, error handling, fixes, Amit Shah, 2010/04/07
- [Qemu-devel] [PATCH 1/8] virtio-serial: throttling: check for throttled status before sending any data, Amit Shah, 2010/04/07
- [Qemu-devel] [PATCH 2/8] virtio-serial: Unthrottle ports once they're closed, Amit Shah, 2010/04/07
- [Qemu-devel] [PATCH 3/8] virtio-serial: Discard unconsumed data before sending port close event, Amit Shah, 2010/04/07
- [Qemu-devel] [PATCH 4/8] virtio-serial: Bus info message for showing port's throttled status, Amit Shah, 2010/04/07
- [Qemu-devel] [PATCH 5/8] char: Let writers know how much data was written in case of errors,
Amit Shah <=
- [Qemu-devel] [PATCH 6/8] char: unix: For files that are nonblocking, report -EAGAIN to calling functions, Amit Shah, 2010/04/07
- [Qemu-devel] [PATCH 7/8] virtio-console: Factor out common init between console and generic ports, Amit Shah, 2010/04/07
- [Qemu-devel] [PATCH 8/8] virtio-console: Throttle virtio-serial-bus if we can't consume any more guest data, Amit Shah, 2010/04/07
[Qemu-devel] Re: [PATCH 0/8] (v2) chardev, virtio-console: flow control, error handling, fixes, Paul Brook, 2010/04/07