[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Add qerror message if the 'change' target filen
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH] Add qerror message if the 'change' target filename can't be opened |
Date: |
Thu, 1 Apr 2010 15:22:33 -0300 |
On Thu, 1 Apr 2010 15:15:51 -0300
Luiz Capitulino <address@hidden> wrote:
> On Thu, 25 Mar 2010 09:32:58 -0500
> Ryan Harper <address@hidden> wrote:
>
> > Currently when using the change command to switch the file in the cd drive
> > the command doesn't complain if the file doesn't exit or can't be opened
> > and the drive keeps the existing image. This patch adds a qerror_report
> > call to print a message out indicating the failure. This error message
> > can be used to catch failures.
>
> Looks good to me, but it doesn't keep the existing image, it will silently
> eject it instead.
And, thinking more about it this seems the wrong behavior to me, if it
fails to open the file, it should not touch the current one.
Am I right, Kevin?