Re: [Qemu-devel] [PATCH 7/7] Refactor target specific handling, compile vl.c only once

[Anthony Liguori]

On 03/31/2010 02:19 PM, Blue Swirl wrote:
> On 3/31/10, Anthony Liguori<address@hidden>  wrote:
>    
> > On 03/27/2010 05:11 PM, Blue Swirl wrote:
> >
> >      
> > > Move target specific functions and RAM handling to arch_init.c.
> > >
> > > Add a flag to QEMUOptions structure to indicate for which
> > > architectures the option is allowed, check the flag
> > > in run time and remove conditional code in option handling.
> > >
> > > Now that no target dependencies remain, compile vl.c only once
> > > for all targets.
> > >
> > > Signed-off-by: Blue Swirl<address@hidden>
> > >
> > >
> > >        
> >   This causes -enable-kvm to seg fault.
> >      
> Variable kvm_state is used but it has not been initialized. This is
> because kvm_init is not called. And this happens because CONFIG_KVM is
> not set by config.h when included from vl.c.
>    

I spoke too soon before.  A lot of code depends on if (kvm_enabled()) 
going to 0 so it's a bigger refactoring to fix this once you start 
compiling targets that !defined(CONFIG_KVM)

Regards,

Anthony Liguori