[Qemu-devel] Re: [PATCH v2 11/11] monitor: New commands netdev_add, netdev_del

[Markus Armbruster]

Luiz Capitulino <address@hidden> writes:

> On Mon, 22 Mar 2010 10:48:53 +0100
> Markus Armbruster <address@hidden> wrote:
>
>> Monitor commands to go with -netdev.
>> 
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  net.c           |   57 
>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>>  net.h           |    2 +
>>  qemu-monitor.hx |   30 ++++++++++++++++++++++++++++
>>  3 files changed, 88 insertions(+), 1 deletions(-)
>> 
>> diff --git a/net.c b/net.c
>> index 1f3c39c..80e9025 100644
>> --- a/net.c
>> +++ b/net.c
>> @@ -1122,7 +1122,7 @@ int net_client_init(Monitor *mon, QemuOpts *opts, int 
>> is_netdev)
>>      }
>>  
>>      qerror_report(QERR_INVALID_PARAMETER_VALUE, "type",
>> -                  "a network backend type");
>> +                  "a network client type");
>>      return -1;
>>  }
>>  
>> @@ -1186,6 +1186,61 @@ void net_host_device_remove(Monitor *mon, const QDict 
>> *qdict)
>>      qemu_del_vlan_client(vc);
>>  }
>>  
>> +/**
>> + * do_netdev_add(): Add a host network device
>> + *
>> + * Argument qdict contains
>> + * - "type": the device type, "tap", "user", ...
>> + * - "id": the device's ID (must be unique)
>
>  Consecutive calls of this command in qmp with the same id succeeds, but
> I couldn't understand why.

Thinko.  I'll respin.

>  Other than that looks ok, although I'm not familiar with the device
> handling machinery in qemu.

v3's the charm, I hope.

Thanks!

[...]