[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] qemu: jaso-parser: Output the content of invali
From: |
Richard Henderson |
Subject: |
[Qemu-devel] Re: [PATCH] qemu: jaso-parser: Output the content of invalid keyword |
Date: |
Wed, 24 Mar 2010 10:25:30 -0700 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.8) Gecko/20100301 Fedora/3.0.3-1.fc12 Thunderbird/3.0.3 |
On 03/24/2010 08:12 AM, Amos Kong wrote:
>
> When input some invialid word 'unknowcmd' through QMP port, qemu outputs this
> error message:
> "parse error: invalid keyword `%s'"
> This patch makes qemu output the content of invalid keyword, like:
> "parse error: invalid keyword `unknowcmd'"
>
> Signed-off-by: Amos Kong <address@hidden>
Acked-by: Richard Henderson <address@hidden>
> ---
> json-parser.c | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/json-parser.c b/json-parser.c
> index 579928f..b55d763 100644
> --- a/json-parser.c
> +++ b/json-parser.c
> @@ -12,6 +12,7 @@
> */
>
> #include <stdbool.h>
> +#include <stdarg.h>
>
> #include "qemu-common.h"
> #include "qstring.h"
> @@ -93,7 +94,12 @@ static int token_is_escape(QObject *obj, const char *value)
> */
> static void parse_error(JSONParserContext *ctxt, QObject *token, const char
> *msg, ...)
> {
> - fprintf(stderr, "parse error: %s\n", msg);
> + va_list ap;
> + va_start(ap, msg);
> + fprintf(stderr, "parse error: ");
> + vfprintf(stderr, msg, ap);
> + fprintf(stderr, "\n");
> + va_end(ap);
> }
>
> /**