Re: [Qemu-devel] [PATCH 3/3] S390: Don't compile in virtio-pci

[Blue Swirl]

On 3/24/10, Alexander Graf <address@hidden> wrote:
> Blue Swirl wrote:
>  > On 3/24/10, Alexander Graf <address@hidden> wrote:
>  >
>  >> As soon as virtio-pci.c gets compiled and used on S390 the internal qdev 
> magic
>  >>  gets confused and tries to give us PCI devices instead of S390 virtio 
> devices.
>  >>
>  >>  Since we don't have PCI on S390, we can safely not compile virtio-pci at 
> all.
>  >>
>  >>  In order to do this I added a new config option "CONFIG_PCI" that I 
> enabled
>  >>  for every platform except S390. Thanks to this the change should be a 
> complete
>  >>  nop for every other platform.
>  >>
>  >
>  > The name should be CONFIG_VIRTIO_PCI, CONFIG_PCI would enable
>  > compilation of pci.c.
>  >
>
>
> My idea was to keep the config option generic and rip out all PCI stuff
>  from s390x-softmmu. We don't even do MMIO :-).

In that case you should also rip out all PCI cards.