[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 01/11] error: Put error definitions back in alphabet
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 01/11] error: Put error definitions back in alphabetical order |
Date: |
Thu, 18 Mar 2010 17:33:08 +0100 |
Add suitable comments to help keerp them in order.
Signed-off-by: Markus Armbruster <address@hidden>
---
qerror.c | 12 ++++++++----
qerror.h | 8 +++++---
2 files changed, 13 insertions(+), 7 deletions(-)
diff --git a/qerror.c b/qerror.c
index eaa1deb..4520b0d 100644
--- a/qerror.c
+++ b/qerror.c
@@ -38,6 +38,10 @@ static const QType qerror_type = {
* for example:
*
* "running out of foo: %(foo)%%"
+ *
+ * Please keep the entries in alphabetical order.
+ * Use "sed -n '/^static.*qerror_table\[\]/,/^};/s/QERR_/&/gp' qerror.c | sort
-c"
+ * to check.
*/
static const QErrorStringTable qerror_table[] = {
{
@@ -65,10 +69,6 @@ static const QErrorStringTable qerror_table[] = {
.desc = "Device '%(device)' could not be initialized",
},
{
- .error_fmt = QERR_DEVICE_NOT_ENCRYPTED,
- .desc = "Device '%(device)' is not encrypted",
- },
- {
.error_fmt = QERR_DEVICE_LOCKED,
.desc = "Device '%(device)' is locked",
},
@@ -81,6 +81,10 @@ static const QErrorStringTable qerror_table[] = {
.desc = "Device '%(device)' has not been activated by the guest",
},
{
+ .error_fmt = QERR_DEVICE_NOT_ENCRYPTED,
+ .desc = "Device '%(device)' is not encrypted",
+ },
+ {
.error_fmt = QERR_DEVICE_NOT_FOUND,
.desc = "Device '%(device)' not found",
},
diff --git a/qerror.h b/qerror.h
index dd298d4..a2664ab 100644
--- a/qerror.h
+++ b/qerror.h
@@ -46,6 +46,8 @@ QError *qobject_to_qerror(const QObject *obj);
/*
* QError class list
+ * Please keep the definitions in alphabetical order.
+ * Use "grep '^#define QERR_' qerror.h | sort -c" to check.
*/
#define QERR_BAD_BUS_FOR_DEVICE \
"{ 'class': 'BadBusForDevice', 'data': { 'device': %s, 'bad_bus_type': %s
} }"
@@ -62,9 +64,6 @@ QError *qobject_to_qerror(const QObject *obj);
#define QERR_DEVICE_ENCRYPTED \
"{ 'class': 'DeviceEncrypted', 'data': { 'device': %s } }"
-#define QERR_DEVICE_NOT_ENCRYPTED \
- "{ 'class': 'DeviceNotEncrypted', 'data': { 'device': %s } }"
-
#define QERR_DEVICE_INIT_FAILED \
"{ 'class': 'DeviceInitFailed', 'data': { 'device': %s } }"
@@ -77,6 +76,9 @@ QError *qobject_to_qerror(const QObject *obj);
#define QERR_DEVICE_NOT_ACTIVE \
"{ 'class': 'DeviceNotActive', 'data': { 'device': %s } }"
+#define QERR_DEVICE_NOT_ENCRYPTED \
+ "{ 'class': 'DeviceNotEncrypted', 'data': { 'device': %s } }"
+
#define QERR_DEVICE_NOT_FOUND \
"{ 'class': 'DeviceNotFound', 'data': { 'device': %s } }"
--
1.6.6.1
- [Qemu-devel] [PATCH 00/11] monitor: New commands netdev_add, netdev_del, Markus Armbruster, 2010/03/18
- [Qemu-devel] [PATCH 03/11] error: Convert qemu_opts_create() to QError, Markus Armbruster, 2010/03/18
- [Qemu-devel] [PATCH 02/11] error: New QERR_DUPLICATE_ID, Markus Armbruster, 2010/03/18
- [Qemu-devel] [PATCH 06/11] error: Drop extra messages after qemu_opts_set() and qemu_opts_parse(), Markus Armbruster, 2010/03/18
- [Qemu-devel] [PATCH 01/11] error: Put error definitions back in alphabetical order,
Markus Armbruster <=
- [Qemu-devel] [PATCH 08/11] error: Convert qemu_opts_validate() to QError, Markus Armbruster, 2010/03/18
- [Qemu-devel] [PATCH 05/11] error: Convert qemu_opts_set() to QError, Markus Armbruster, 2010/03/18
- [Qemu-devel] [PATCH 09/11] error: Convert net_client_init() to QError, Markus Armbruster, 2010/03/18
- [Qemu-devel] [PATCH 07/11] error: Use QERR_INVALID_PARAMETER_VALUE instead of QERR_INVALID_PARAMETER, Markus Armbruster, 2010/03/18
- [Qemu-devel] [PATCH 10/11] error: New QERR_DEVICE_IN_USE, Markus Armbruster, 2010/03/18
- [Qemu-devel] [PATCH 11/11] monitor: New commands netdev_add, netdev_del, Markus Armbruster, 2010/03/18
- [Qemu-devel] Re: [PATCH 00/11] monitor: New commands netdev_add, netdev_del, Luiz Capitulino, 2010/03/19