[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 16/50] error: Replace qemu_error() by error_repo
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] Re: [PATCH 16/50] error: Replace qemu_error() by error_report() |
Date: |
Fri, 12 Mar 2010 23:34:14 -0300 |
On Thu, 4 Mar 2010 16:56:37 +0100
Markus Armbruster <address@hidden> wrote:
> error_report() terminates the message with a newline. Strip it it
> from its arguments.
>
> This fixes a few error messages lacking a newline:
> net_handle_fd_param()'s "No file descriptor named %s found", and
> tap_open()'s "vnet_hdr=1 requested, but no kernel support for
> IFF_VNET_HDR available" (all three versions).
>
> There's one place that passes arguments without newlines
> intentionally: load_vmstate(). Fix it up.
>
> Signed-off-by: Markus Armbruster <address@hidden>
I'm starting to queue QMP related patches, so that we test them early,
and this one doesn't apply anymore against HEAD. Didn't investigate much,
though.
If you decide to rebase, remember that we have patches from Shahar
that modify qerror.[hc], my queue is at:
git://repo.or.cz/qemu/qmp-unstable.git (master)
- [Qemu-devel] [PATCH 34/50] error: New QERR_BUS_NOT_FOUND, (continued)
- [Qemu-devel] [PATCH 49/50] monitor: Use argument type 'O' for device_add, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 47/50] qemu-option: Rename find_list() to qemu_find_opts() & external linkage, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 16/50] error: Replace qemu_error() by error_report(), Markus Armbruster, 2010/03/04
- [Qemu-devel] Re: [PATCH 16/50] error: Replace qemu_error() by error_report(),
Luiz Capitulino <=
- [Qemu-devel] [PATCH 24/50] qdev: Factor qdev_create_from_info() out of qdev_create(), Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 19/50] error: Include the program name in error messages to stderr, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 38/50] error: New error_printf_unless_qmp(), Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 20/50] error: Track locations in configuration files, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 46/50] qemu-option: Move the implied first name into QemuOptsList, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 22/50] error: Track locations on command line, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 48/50] monitor: New argument type 'O', Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 29/50] error: Polish human-readable error descriptions, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 21/50] QemuOpts: Fix qemu_config_parse() to catch file read errors, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 32/50] qdev: convert setting device properties to QError, Markus Armbruster, 2010/03/04