Re: [Qemu-devel] Re: [PATCH] CODING_STYLE: Reserve qemu_ prefix for library wrappers

[Jamie Lokier]

Anthony Liguori wrote:
> On 03/11/2010 08:48 AM, Avi Kivity wrote:
> >Signed-off-by: Avi Kivity<address@hidden>
> >---
> >  CODING_STYLE |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> >
> >diff --git a/CODING_STYLE b/CODING_STYLE
> >index a579cb1..92036f3 100644
> >--- a/CODING_STYLE
> >+++ b/CODING_STYLE
> >@@ -49,6 +49,9 @@ and is therefore likely to be changed.
> >  Typedefs are used to eliminate the redundant 'struct' keyword.  It is the
> >  QEMU coding style.
> >
> >+When wrapping standard library functions, use the prefix qemu_ to alert
> >+readers that they are seeing a wrapped version; otherwise avoid this 
> >prefix.
> >+
> >   
> 
> Acked-by: Anthony Liguori <address@hidden>
> 
> But I'd like to also see others agree with this.

I agree - not that I've contributed any code, mind you, but I do read
bits of it from time to time.

However if qemu is ever made into a library used by other
applications, i.e. libqemu.a or libqemu.so, then you might decide
application-visible functions should have the prefix

-- Jamie